[Xamarin.MacDev] Add a PDictionary.TryGetStringValue method. #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds a convenience method TryGetStringValue to the PDictionary class that simplifies retrieving string values from property list dictionaries without requiring explicit handling of the PString wrapper type.
Key Changes:
- Added
TryGetStringValuemethod that returns the underlying string value directly instead of requiring callers to unwrapPStringobjects
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+680
to
+689
| public bool TryGetStringValue (string key, [NotNullWhen (true)] out string? value) | ||
| { | ||
| if (TryGetValue<PString> (key, out var obj)) { | ||
| value = obj.Value; | ||
| return true; | ||
| } | ||
|
|
||
| value = null; | ||
| return false; | ||
| } |
There was a problem hiding this comment.
The new TryGetStringValue method lacks test coverage. Consider adding tests to verify:
- Successful retrieval of a string value when the key exists and contains a PString
- Returning false and null when the key doesn't exist
- Returning false and null when the key exists but contains a non-string value (e.g., PNumber, PBoolean)
This is especially important since the existing TryGetValue method has comprehensive test coverage in PListObjectTests.cs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.