[release/8.0] Disable flaky ETW manifest generation tests in release/8.0#126008
[release/8.0] Disable flaky ETW manifest generation tests in release/8.0#126008Copilot wants to merge 1 commit intorelease/8.0from
Conversation
|
@copilot you got mixed up. you should be targeting the 8.0 branch. |
The code change itself is correct — I've prepared a clean branch The issue is this PR was auto-created targeting
The diff will then show only the 2 lines: + [ActiveIssue("https://github.com/dotnet/runtime/issues/88027")]
public void Test_EventSource_EtwManifestGeneration()
...
+ [ActiveIssue("https://github.com/dotnet/runtime/issues/88027")]
public void Test_EventSource_EtwManifestGenerationRollover() |
Co-authored-by: danmoseley <6385855+danmoseley@users.noreply.github.com> Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/415b0f89-5a75-45c4-b0ed-e274d2f522a5
efdd044 to
66cea92
Compare
|
@steveisok I believe I have to ask you to add the "Servicing-approved" label |
There was a problem hiding this comment.
Pull request overview
Backports the test disabling used on newer branches to release/8.0 to stop persistent CI flakes in ETW manifest generation tests in System.Diagnostics.Tracing.
Changes:
- Adds
[ActiveIssue("https://github.com/dotnet/runtime/issues/88027")]toTest_EventSource_EtwManifestGeneration. - Adds
[ActiveIssue("https://github.com/dotnet/runtime/issues/88027")]toTest_EventSource_EtwManifestGenerationRollover.
main PR #105069
Description
Test_EventSource_EtwManifestGenerationandTest_EventSource_EtwManifestGenerationRolloverare consistently flaky onrelease/8.0due to the old double-RemoteExecutorpattern and timing-based retry loops. These tests have been unconditionally disabled via[ActiveIssue]onmain,release/9.0, andrelease/10.0, but the attribute was never backported torelease/8.0.Adds
[ActiveIssue("https://github.com/dotnet/runtime/issues/88027")]to both tests inTestsManifestGeneration.Etw.cs:This PR targets the
release/8.0branch. A clean branch (copilot/fix-etw-test-8.0) based directly onrelease/8.0is available with just this 2-line fix.Customer Impact
Ongoing CI noise on every
release/8.0servicing PR. No customer-facing behavioral change.Regression
No — this is a pre-existing flaky test, not a regression introduced in the latest release.
Testing
No new tests. The fix is to skip tests that are already skipped on all newer branches. Verified
[ActiveIssue]attribute matches the form used onmain/release/9.0/release/10.0.Risk
Minimal. Two-line change disabling already-flaky tests. No production code touched. Identical pattern already proven stable on three other branches.
Package authoring signed off?
N/A — test-only change, no NuGet packages affected.
Original prompt
This section details on the original issue you should resolve
<issue_title>BasicEventSourceTests.TestsManifestGeneration.Test_EventSource_EtwManifestGeneration is failing in CI</issue_title>
<issue_description>## Build Information
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=1091361
Build error leg or test failing: BasicEventSourceTests.TestsManifestGeneration.Test_EventSource_EtwManifestGeneration
Pull request: #116534
Error Message
Fill the error message using step by step known issues guidance.
{ "ErrorMessage": ["BasicEventSourceTests.TestsManifestGeneration.Test_EventSource_EtwManifestGeneration", "Microsoft.DotNet.RemoteExecutor.RemoteExecutionException : Remote process failed with an unhandled exception."], "ErrorPattern": "", "BuildRetry": false, "ExcludeConsoleLog": false }Known issue validation
Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=1091361
Error message validated:
[BasicEventSourceTests.TestsManifestGeneration.Test_EventSource_EtwManifestGeneration Microsoft.DotNet.RemoteExecutor.RemoteExecutionException : Remote process failed with an unhandled exception.]Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 7/10/2025 9:17:28 PM UTC
Report
Summary
<agent_instructions>Disable both of these in the 8.0 branch (ONLY) using
[ActiveIssue("https://github.com/dotnet/runtime/issues/88027")They already have that disabling in 9, 10, and main.</agent_instructions>
Comments on the Issue (you are @copilot in this section)
@danmoseley > [!NOTE] > This analysis was generated with assistance from GitHub Copilot.Root Cause: Failures are exclusively from
release/8.0All recent failures tracked by this issue (and the related #88027 for the Rollover variant) are coming from the
release/8.0branch. The PRs in the Known Build Error hit tables confirm this — they are allrelease/8.0servicing PRs (dependency updates, staging merges, etc.).Why
release/8.0is differentBetween Nov 2023 and Jul 2024, six PRs landed on
mainto address this test:⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.