[wasm][coreclr] Disable structinreg P/Invoke test on platforms without native test assets#126019
Merged
radekdoulik merged 3 commits intodotnet:mainfrom Mar 26, 2026
Merged
Conversation
…sets The test is disabled until native linking is ready on wasm/coreclr. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/runtime-infrastructure |
28 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Disables the structinreg System V bring-up test entrypoint on platforms that currently don’t support native test assets (required due to DllImport("jitstructtests_lib") usage in the test suite), aligning with the infra limitations tracked in #123946.
Changes:
- Adds an
[ActiveIssue]guard to skip the test whenPlatformDetection.PlatformDoesNotSupportNativeTestAssetsis true. - Adds a
TestLibraryusing to support the new platform detection reference.
maraf
approved these changes
Mar 24, 2026
Member
Author
|
/ba-g the timeouts are unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR description was AI/Copilot-generated.
Summary
Disables the structinreg P/Invoke test until native linking is ready on wasm/coreclr. The test uses
[DllImport("jitstructtests_lib")]which requires native test assets.Tracked by #123946