Fix haiku and illumos x64 builds - #131700
Open
am11 wants to merge 2 commits into
Open
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
|
Azure Pipelines: Successfully started running 6 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
am11
added
area-Infrastructure
os-SunOS
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
am11
force-pushed
the
chore/fix-community-platform-builds
branch
2 times, most recently
from
August 1, 2026 18:21
344d833 to
15f2342
Compare
am11
commented
Aug 1, 2026
Comment on lines
10509
to
+10511
| LclVarDsc* varDsc = lvaGetDesc(lclNum); | ||
| if ((varDsc->TypeGet() == type) && ((type != TYP_STRUCT) || layout->CanAssignFrom(varDsc->GetLayout()))) | ||
| if ((varDsc->TypeGet() == type) && | ||
| ((type != TYP_STRUCT) || (layout != nullptr && layout->CanAssignFrom(varDsc->GetLayout())))) |
Member
Author
There was a problem hiding this comment.
@jakobbotsch, illumos gcc thinks that it can be null here from the path followed by gtNewLoadValueNode(JITtype2varType(constraintTyp), nullptr, obj); (as JITtype2varType can return non TYP_STRUCT type). I think error was seen with release config only given the assert at the start of this method, but not sure.
am11
force-pushed
the
chore/fix-community-platform-builds
branch
14 times, most recently
from
August 1, 2026 21:19
3df4f11 to
302d268
Compare
am11
force-pushed
the
chore/fix-community-platform-builds
branch
from
August 1, 2026 21:51
302d268 to
3c00744
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding
_X, the alternative was to rename it toPAL_Xeverywhere but that turned it into a 1400+ lines of change; can apply if needed.