fix: correct length field size, reserved tag range, and flaky test assertion#95
Merged
gaius-qi merged 1 commit intoJun 2, 2026
Conversation
immanuwell
requested review from
LunaWhispers,
bergwolf,
fcgxz2003,
hhhhsdxxxx,
imeoer and
mingcheng
…sertion Signed-off-by: immanuwell <pchpr.00@list.ru>
immanuwell
force-pushed
the
fix/doc-and-test-inaccuracies
branch
from
3d748cd to
ffbf438
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Few small inaccuracies found while reading the code:
Vortexdoc comment says Length field is 8 bytes, but it'sput_u32(4 bytes). Same comment says max value is 1 GiB butMAX_VALUE_SIZEis 4 GiB.From<Vortex> for Bytesimpl has a copy-paste comment sayingFrom<PieceContent>.test_header_newassertsheader.id <= 254, butrng.gen::<u8>()produces 0-255, so it fails ~1/256 runs whenid == 255.Reservedtag comment says "for tags 6-254", correct range is 8-253 (6 and 7 are defined, 254 isClose). Same issue indocs/README.md.Related Issue
No open issue - doc/comment/test fixes only.
Motivation and Context
Flaky test repro: run
cargo test tests::test_header_newrepeatedly, panics whenid == 255.