Repository navigation
fix: Restore composition error cap that stops collecting, not iterating (#54) - #75
Open
shadowhand wants to merge 1 commit into
Open
shadowhand wants to merge 1 commit into
shadowhand wants to merge 1 commit into
Conversation
…ng (duyler#54) Merge 5560ac4 resolved a conflict in AbstractCompositionalValidator by keeping the early return at the error cap, undoing 8edf71a. Branches after the cap were never evaluated, so anyOf/oneOf could miss a later match and CompositionBranchOrderIndependenceTest failed on CI. Only error collection now stops at the cap. allOf counts every failed branch, so its test expects 3 failed rather than 2.
Contributor
Author
|
Build is failing because of a Sonar auth issue, perhaps an expired token. Nothing I can do about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CompositionBranchOrderIndependenceTestfails onmain(3 tests). The #54 fix (8edf71a) was undone by merge 5560ac4: resolving a conflict inAbstractCompositionalValidator::validateSchemas()kept the earlyreturnatMAX_COMPOSITION_ERRORS. Branches after the cap were never evaluated, soanyOf/oneOfcould miss a later matching branch and report "none did".Fix
Only error collection stops at the cap (
$cappedflag); every branch is still evaluated and counted. Output is unchanged: 20 errors plus oneTooManyErrorsError.allOfnow reports the true number of failed branches.all_of_still_fails_when_a_branch_after_the_error_cap_failsexpected2 failedfrom the old counting, which only counted branches whose errors were collected before the cap. Three branches fail there, so it now expects3 failed.Verification
Full PHPUnit suite and psalm pass locally. Added a CHANGELOG entry under
[Unreleased].Refs #54