ci: guard release commit push against concurrent merges#1469
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 57d17ff. Bugbot is set up for automated code reviews on this repo. Configure here. |
Package ArtifactsBuilt from af3906e. Download artifacts from this workflow run. JS SDK ( npm install ./e2b-2.30.4-mishushakov-fix-release-commit-push-race.0.tgzCLI ( npm install ./e2b-cli-2.12.2-mishushakov-fix-release-commit-push-race.0.tgzPython SDK ( pip install ./e2b-2.29.3+mishushakov.fix.release.commit.push.race-py3-none-any.whl |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c24b051504
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The release "Commit new versions" step pushed without a rebase, so a PR merging mid-release failed the push and the whole release. A plain
git pull --rebasewould fix that but could rebase the version bump onto concurrently-merged package code that was never in the published artifacts — a silent source↔artifact divergence.This guards the rebase: on a non-fast-forward push, it only rebases when the incoming changes don't touch
packages/; if they do, it fails loudly for manual reconciliation.🤖 Generated with Claude Code