debug: test-only FullChunkCachedAfterPartialRequest#2125
Closed
Conversation
Add error logging to the Eventually condition so CI failures show whether Slice blocks (no logs) or returns persistent errors. Run both the Eventually and direct variants 100 times each to increase the chance of hitting the race in a single CI run. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
packages/orchestrator/internal/sandbox/block/streaming_chunk_test.go
Outdated
Show resolved
Hide resolved
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cd637c2b57
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
packages/orchestrator/internal/sandbox/block/streaming_chunk_test.go
Outdated
Show resolved
Hide resolved
…achedAfterPartialRequest testify's Eventually runs conditions in goroutines, creating a race with defer Close() when the timeout fires while the condition goroutine is blocked in registerAndWait. Replace with a direct blocking Slice call (which is what production uses) with an explicit 10s timeout context. Also removes the eventually/direct dimension (200 → 100 subtests). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…of github.com:e2b-dev/infra into lev-debug-FullChunkCachedAfterPartialRequest-flapping
…hunker Same upstream, same flow (Slice first block → Slice last block), same iteration count. If CI shows >1s warnings on streaming but not full-fetch, the cause is background goroutine starvation, not general CI load. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Log first_slice and second_slice durations separately when >100ms so we can identify exactly which phase is slow on CI. Lower WARNING threshold from 1s to 100ms. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…tests Remove 100x loop, remove apples-to-apples timing test. Keep the fix: replace flaky Eventually with direct blocking Slice, add 10ms slow warning for visibility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…erPartialRequest Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jakubno
approved these changes
Mar 16, 2026
…unkCachedAfterPartialRequest-flapping
Contributor
Author
|
Looks like @dobrac merged it with one of his PRs already, no diff to |
ValentaTomas
deleted the
lev-debug-FullChunkCachedAfterPartialRequest-flapping
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed to reproduce, removed the
Eventuallyand added logging for slow results.This is to debug the flaky behavior manifested here, https://github.com/e2b-dev/infra/actions/runs/23020326855/job/66854698657?pr=2120