fix(template-manager): handle error gracefully if metadata already exists#2130
Merged
fix(template-manager): handle error gracefully if metadata already exists#2130
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
packages/orchestrator/internal/template/build/storage/cache/cache.go
Outdated
Show resolved
Hide resolved
packages/orchestrator/internal/template/build/storage/cache/cache.go
Outdated
Show resolved
Hide resolved
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33dcc86c7e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
packages/orchestrator/internal/template/build/storage/cache/cache.go
Outdated
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
packages/orchestrator/internal/template/build/storage/cache/cache.go
Outdated
Show resolved
Hide resolved
dobrac
approved these changes
Mar 20, 2026
packages/orchestrator/internal/template/build/storage/cache/cache.go
Outdated
Show resolved
Hide resolved
jakubno
force-pushed
the
fix/handle-rate-limit-error
branch
2 times, most recently
from
a17b6ff to
59a4556
Compare
jakubno
force-pushed
the
fix/handle-rate-limit-error
branch
from
59a4556 to
cd9b4ae
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
dobrac
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes storage write error handling to treat GCS
ResourceExhaustedas a special rate-limit case and skip layer-metadata writes in that scenario, which could mask unexpected storage failures if misclassified.Overview
Improves resilience when multiple builds race to write the same content-addressed layer metadata by detecting GCS per-object mutation rate limiting (
ResourceExhausted) asstorage.ErrObjectRateLimitedand having the layer build executor skip the metadata write (with a warning) instead of failing the build.Written by Cursor Bugbot for commit fbbea63. This will update automatically on new commits. Configure here.