fix(orch): set mmds early to fix a race condition for snapshot templates#2138
Closed
fix(orch): set mmds early to fix a race condition for snapshot templates#2138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
Note
Medium Risk
Changes the ordering of snapshot resume steps, which can affect VM bring-up timing and failure modes if MMDS or resume calls behave differently than expected. Risk is limited in scope to the Firecracker snapshot resume path.
Overview
Fixes a race during snapshot-based VM resume by moving the MMDS metadata write (
setMmds) to occur beforeresumeVM, ensuring sandbox/template/logging metadata (and access-token hash) is available immediately when the VM comes up.Written by Cursor Bugbot for commit 0954b5a. This will update automatically on new commits. Configure here.