Fix typos and cleanup in AWS self-host infrastructure#2213
Merged
jakubno merged 2 commits intoe2b-dev:mainfrom Mar 24, 2026
Merged
Fix typos and cleanup in AWS self-host infrastructure#2213jakubno merged 2 commits intoe2b-dev:mainfrom
jakubno merged 2 commits intoe2b-dev:mainfrom
Conversation
- Rename misspelled `vcp_availability_zones` to `vpc_availability_zones` across network module - Fix typo "nots" -> "not" in VPC endpoint comment - Remove duplicate TERRAFORM_ENVIRONMENT in .env.aws.template https://claude.ai/code/session_013AbL8FdtWDH2HRWwfDubSr
ya-luotao
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
…or job Add grafana_logs_user, grafana_logs_endpoint, and grafana_api_key to the AWS provider's logs-collector module, matching the existing GCP pattern. This enables forwarding logs to Grafana Cloud from AWS deployments. Changes: - Add LOGS_USER, LOGS_URL, LOGS_COLLECTOR_API_TOKEN to the grafana secret in AWS init module and expose them in the output - Add grafana_logs_user, grafana_logs_endpoint, grafana_logs_api_key variables to the AWS nomad module - Pass the variables through to the shared job-logs-collector module - Wire secrets from init module through main.tf to the nomad module https://claude.ai/code/session_013AbL8FdtWDH2HRWwfDubSr
jakubno
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Typo & cleanup fixes
vcp_availability_zonestovpc_availability_zonesacross the network module (3 files)modules/network/main.tf)TERRAFORM_ENVIRONMENTdeclaration in.env.aws.templateWire Grafana logs forwarding (parity with GCP)
LOGS_USER,LOGS_URL, andLOGS_COLLECTOR_API_TOKENfields to the existing Grafana secret in AWS Secrets Managergrafana_logs_user,grafana_logs_endpoint, andgrafana_api_keyvariables through the AWS provider into the sharedjob-logs-collectormoduleTest plan
terraform planruns without errors (variable rename is consistent across all references)grafana_loki_outputsink%{ if }conditional invector.toml