Add missing PostHog and analytics collector secrets to AWS provider#2215
Add missing PostHog and analytics collector secrets to AWS provider#2215ya-luotao wants to merge 3 commits intoe2b-dev:mainfrom
Conversation
Add posthog-api-key and analytics-collector secrets to AWS Secrets Manager, matching GCP parity. Wire them through to the job-api module so the API service can report product analytics and custom analytics events. https://claude.ai/code/session_013AbL8FdtWDH2HRWwfDubSr
ya-luotao
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13bcb8ba63
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| posthog_api_key = module.init.posthog_api_key | ||
| analytics_collector_host = module.init.analytics_collector.host | ||
| analytics_collector_api_token = module.init.analytics_collector.api_token |
There was a problem hiding this comment.
The new AWS wiring forwards module.init.posthog_api_key and module.init.analytics_collector.* directly, but these secrets are initialized to a single space (" ") in iac/provider-aws/init/secrets.tf and are never trimspaced on this path. In fresh environments (or any environment still using placeholders), API receives whitespace-only values instead of empty strings, so empty-config guards won’t behave like the GCP path (which trims) and integrations may be treated as configured with invalid credentials/host values.
Useful? React with 👍 / 👎.
The posthog_api_key and analytics_collector secrets are initialized to " " in Secrets Manager. Without trimspace, empty-config guards receive whitespace instead of empty strings, diverging from the GCP path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Keep both upstream grafana_logs_* variables and our posthog/analytics collector variables. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Thanks for your contribution, we decided we don't want to support PostHog and analytics collector for non-enterprise deployment options. |
4 participants
Summary
posthog-api-keysecret to AWS Secrets Manager (matches GCP'sposthog-api-key)analytics-collectorsecret withHOSTandAPI_TOKENfields (matches GCP'sanalytics-collector-hostandanalytics-collector-api-token)posthog_api_key,analytics_collector_host, andanalytics_collector_api_tokenthrough to thejob-apimoduleignore_changeslifecycle, matching existing AWS secrets patternTest plan
terraform planshows 3 new secrets (posthog-api-key, analytics-collector) and updated API job template