Skip to content

bugfix: centered header-menu items in <NodeContent /> #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haschek merged 2 commits into from
Jan 12, 2026
Merged

bugfix: centered header-menu items in <NodeContent /> #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
972d701
bugfix: centered header-menu items in <NodeContent />
fiorsaoirse Dec 11, 2025
6af2e32
Merge remote-tracking branch 'origin/develop' into bugfix/centeredNod…
haschek Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
- reduce visual impact of border
- `<StringPreviewContentBlobToggler />`
- take Markdown rendering into account before testing the maximum preview length
- `<NodeContent />`
- header-menu items are vertically centered now

### Changed

Expand Down
7 changes: 4 additions & 3 deletions src/extensions/react-flow/nodes/_nodes.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@
border-radius: $reactflow-node-border-radius;

&:hover {
box-shadow: 0 0 0 6 * $reactflow-node-border-width eccgui-color-rgba($reactflow-edge-stroke-color-selected, 0.05);
box-shadow: 0 0 0 6 * $reactflow-node-border-width
eccgui-color-rgba($reactflow-edge-stroke-color-selected, 0.05);
}

&.was-resized.is-resizable-vertical {
Expand Down Expand Up @@ -147,8 +148,10 @@

.#{$eccgui}-graphviz__node__header-depiction,
.#{$eccgui}-graphviz__node__header-menu {
display: flex;
flex-grow: 0;
flex-shrink: 0;
align-items: center;
max-height: calc(#{$reactflow-node-basesize} - #{2 * $reactflow-node-border-width});
margin: 0 $eccgui-size-block-whitespace * 0.25;

Expand All @@ -158,8 +161,6 @@
}

.#{$eccgui}-graphviz__node__header-depiction {
display: flex;
align-items: center;
justify-content: center;

/* TODO: does not work correctly with tooltips around
Expand Down
Loading