feat: Add logged in user identity cache key#1709
Open
autumnfound wants to merge 3 commits intoeclipse-openvsx:masterfrom
Open
feat: Add logged in user identity cache key#1709autumnfound wants to merge 3 commits intoeclipse-openvsx:masterfrom
autumnfound wants to merge 3 commits intoeclipse-openvsx:masterfrom
Conversation
To cover logged in user sessions more cleanly when resolving identities, a new cachekey prefix was added to IdentityService.resoveIdentity. This "user_" prefix is used when there is an identifiable user session for the current request. Resolves EclipseFdn/open-vsx.org#8954
autumnfound
force-pushed
the
malowe/master/open-vsx.org-8954
branch
from
99bf092 to
b6d34eb
Compare
Contributor
|
The idea of the referenced ticket is to use a different cache key for the identified entity. In case a token is used, do not use the token hash, but instead use the id of the referenced user. So that when a user uses different tokens, they are all in the same bucket instead of separate ones. |
Contributor
Author
Ahh gotcha, so user should be first, and then everything else. That's an easy fix, I'll update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To cover logged in user sessions more cleanly when resolving identities, a new cachekey prefix was added to IdentityService.resoveIdentity. This "user_" prefix is used when there is an identifiable user session for the current request.
Resolves EclipseFdn/open-vsx.org#8954