Skip to content

Conversation

@amartya4256
Copy link
Contributor

This PR adds the documentation about SWT's new Coordinate system which aids to the monitor specific scaling on windows.

@amartya4256 amartya4256 linked an issue Jan 27, 2026 that may be closed by this pull request
@amartya4256 amartya4256 force-pushed the amartya4256/coordinate_system_documentation branch 2 times, most recently from 4caea9a to 1a6a6e1 Compare January 27, 2026 15:32
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

Test Results

  176 files  + 7    176 suites  +7   27m 12s ⏱️ - 2m 53s
4 684 tests +57  4 662 ✅ +55  22 💤 +3  0 ❌  - 1 
  485 runs  +57    479 ✅ +54   6 💤 +3  0 ❌ ±0 

Results for commit 51e0349. ± Comparison against base commit 9acbc6f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having documentation of the coordinate system specifics is a good idea. Thank you.

The current text more sounds like an experience report / article than a documentation of results. It also does align with the terminology in the rest of the documentation. Can we align that?
As an example, the documentation introduced the "static" and the "dynamic" HiDPI support, for which the different coordinate system apply. So explaining the relation between those terms of the different coordinate system would be helpful. Actually, the current description is not completely correct in that regard, as it states that when all monitors have the same zoom, the SingleZoomCoordinateSystemMapper is used, but it only depends on the used HiDPI mode and not on the zooms of the monitors.

The images are also quite nice, but in my opinion they would be more helpful if they reflected how the coordinate systems actually work and not how a wrong coordinate system would look like.

@amartya4256 amartya4256 force-pushed the amartya4256/coordinate_system_documentation branch 5 times, most recently from 52cb9b4 to a7dd726 Compare January 30, 2026 15:37
This Commit adds the documentation about SWT's new Coordinate system
which aids to the monitor specific scaling on windows.
@amartya4256 amartya4256 force-pushed the amartya4256/coordinate_system_documentation branch from a7dd726 to 333ec9e Compare January 30, 2026 15:38
@HeikoKlare
Copy link
Contributor

Only changing docs, which are not checked by CI. Thus merging before CI is done.

@HeikoKlare HeikoKlare merged commit a7290ba into eclipse-platform:master Jan 30, 2026
18 of 19 checks passed
@HeikoKlare HeikoKlare deleted the amartya4256/coordinate_system_documentation branch January 30, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Coordinate System Documentation

2 participants