Fix console input cursor not repositioning after output - #2849
Conversation
Test Results 54 files ±0 54 suites ±0 1h 0m 22s ⏱️ + 2m 8s For more details on these failures, see this check. Results for commit 0593ec6. ± Comparison against base commit 7beef1c. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull request overview
This PR addresses Eclipse console usability by ensuring the input caret is repositioned to the next writable input partition after program output is written, aligning behavior with expectations described in issue #2127.
Changes:
- Added
repositionCaretAfterOutput()toIOConsoleViewerto move the caret to the next writable input partition. - Invoked caret repositioning after auto-scroll reveals the end of the document on document change events.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8d4fd59 to
576aed1
Compare
|
OK, looks good from the code point of view, tested with this snippet: Could you please add a test for this fix? |
576aed1 to
011f8b6
Compare
Added repositionCaretAfterOutput() to IOConsoleViewer to move the caret to the next writable input partition whenever output is written. Fixes : eclipse-platform#2127
011f8b6 to
0593ec6
Compare
Added, |
|
Hmm. The failing tests are all about "not yet closed/disposed" consoles, interestingly they are all different and failing in different OS. The common thing is that some console is still "alive" and not closed. |
Added repositionCaretAfterOutput() to IOConsoleViewer to move the caret to the next writable input partition whenever output is written.

Before :
After :

Fixes : #2127