Initial mw::com-based implementation of ilmcontrol interface by NicolasFussberger · Pull Request #478 · eclipse-score/lifecycle

NicolasFussberger · 2026-08-17T09:18:03Z

Initial implementation of the ilm_control interface using mw::com as the underlying communication framework.
This PR only implements the library-side.
Follow up PR will adapt the launch_manager daemon code to interact with the library via mw::com.

Closes: #480

github-actions · 2026-08-17T09:19:18Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 56b5aaaa-ae6e-4b80-bca8-ef8553316d59
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (26 packages loaded, 10 targets configured)

Analyzing: target //:license-check (87 packages loaded, 10 targets configured)

Analyzing: target //:license-check (90 packages loaded, 10 targets configured)

Analyzing: target //:license-check (152 packages loaded, 3161 targets configured)

Analyzing: target //:license-check (164 packages loaded, 6285 targets configured)

Analyzing: target //:license-check (164 packages loaded, 6285 targets configured)

Analyzing: target //:license-check (172 packages loaded, 9567 targets configured)

Analyzing: target //:license-check (176 packages loaded, 11463 targets configured)

Analyzing: target //:license-check (176 packages loaded, 11463 targets configured)

INFO: Analyzed target //:license-check (177 packages loaded, 11589 targets configured).
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 25.296s, Critical Path: 0.20s
INFO: 16 processes: 4 disk cache hit, 12 internal.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

github-actions · 2026-08-17T09:31:39Z

The created documentation from the pull request is available at: docu-html

danth · 2026-08-19T08:45:06Z

@NicolasFussberger There are merge conflicts 😄

…based_api

NicolasFussberger · 2026-08-19T09:34:25Z

@NicolasFussberger There are merge conflicts 😄

Resolved. Though I had to downgrade again to baselibs 0.2.10, because com is not working with baselibs 0.2.11 yet.

danth · 2026-08-19T10:22:22Z

+
+# mw::com reads its manifest from the working-directory-relative default path
+# ./etc/mw_com_config.json unless told otherwise via CLI args.
+# CLI args are currently not supported with score_qnx_unit_tests, so


Support was added in eclipse-score/qnx_unit_tests@21f6901

MaciejKaszynski · 2026-08-20T08:14:13Z

            case ExecErrc::kFailedUnexpectedTerminationOnEnter:
                return "Unexpected Termination during transition in Process of target Process Group State happened";
            case ExecErrc::kInvalidTransition:
                return "Transition invalid (e.g. report kRunning when already in Running Process State)";


Do you think we should further clarify kInvalidTransition I think this was currently use this for what kRunTargetDoesntExist says.

MaciejKaszynski · 2026-08-20T08:23:55Z

+class LmControlService : public Trait::Base
+{
+  public:
+    using Trait::Base::Base;


I'm guessing this Trait is coming from COM? Can you add a comment to explain this?

MaciejKaszynski · 2026-08-20T08:27:07Z

+{
+
+/// @brief Translates a RunTargetActivationSource to a human-readable string for logging.
+constexpr std::string_view toStringView(const RunTargetActivationSource source) noexcept


Can you make this into an ostream <<operator or mw::log::LogStream <<operator instead?

MaciejKaszynski · 2026-08-20T08:28:19Z

+        case RunTargetActivationSource::kRecoveryAction:
+            return "RecoveryAction";
+    }
+    return "Unknown";


I think it's nice to SCORE_LANGUAGE_FUTURECPP_UNREACHABLE(); here because then you should get compiler errors if all cases are not handled.

MaciejKaszynski · 2026-08-20T08:36:12Z

+#include "score/mw/com/types.h"
+#include "score/mw/lifecycle/ilm_control.hpp"
+
+namespace score::mw::lifecycle


should this be in internal? I think all of the files in detail

MaciejKaszynski · 2026-08-20T08:49:06Z

Do you think it would be good to make some sort of component test that includes actual com implementation? I think this could be good when trying to debug interactions between us and COM.

MaciejKaszynski · 2026-08-20T08:53:38Z

+            return score::MakeUnexpected(ExecErrc::kInvalidArguments);
+        }
+
+        const auto start_result = Traits::StartFindService(


With the interactions with COM could you not use auto as developers unfamiliar would have no idea what the type could be.

TimoSteuerwaldETAS · 2026-08-20T14:15:32Z

+///                 traits type whose Proxy is a fake, giving full control
+///                 for testing.
+template <typename Traits = MwComProxyTraits>
+class BasicLmControlImpl final : public ILmControl


Clever idea to encapsulate the mwcom api with a traits type. 🤓

TimoSteuerwaldETAS · 2026-08-20T15:03:53Z

+            const auto stop_result = Traits::StopFindService(find_handle_.value());
+            if (!stop_result.has_value())
+            {
+                LM_LOG_ERROR() << "LmControl: StopFindService failed with error:" << stop_result.error();


To my understanding this object is living in a state manager daemon, however it uses lm logging macros which are meant to be used inside lm daemon. Should be better a separate logger like LM(C)I (like Launch Manager (Control) Interface) to see already from the log statement that this code has been not executed in the daemon.

TimoSteuerwaldETAS · 2026-08-20T16:49:32Z

    ///          abstraction to expose at this level. Do not treat this interface
    ///          as stable until these decisions are resolved.
    ///
    /// Establishes the mw::com connection to the Launch Manager.


Is really the connection established or only initiated? What happens synchronously, what asynchronously?

TimoSteuerwaldETAS · 2026-08-20T17:00:57Z

+    /// @param[in] callback The callback to invoke, may be empty in which case the sample is dropped.
+    /// @param[in] sample   The received activation result.
+    template <typename SamplePtrType>
+    static void forwardSample(const ActivationCallback& callback, const SamplePtrType& sample) noexcept


This method is noexcept, but ActivationCallback isn't, which could lead to std::terminate.
However there is no easy way out with std::function and C++17: https://stackoverflow.com/a/31675003

TimoSteuerwaldETAS · 2026-08-20T17:06:24Z

+            }
+        }
+
+        if (proxy_.has_value())


Does the mutex need to be acquired before accessing proxy_?

TimoSteuerwaldETAS · 2026-08-20T17:09:46Z

+        }
+    }
+
+    score::Result<void> activate_run_target(RunTargetName runTargetName, bool force = false) override


Default value could be dropped here, as it is defined in the interface.

TimoSteuerwaldETAS · 2026-08-20T17:10:45Z

+#include <string>
+#include <string_view>
+
+#include "score/mw/com/runtime.h"


Unused include

SimonKozik and others added 19 commits August 14, 2026 11:18

Saving current status

611a4c3

Removing unneeded call to GetNewSamples

22d6798

Saving fixed versions for polling and SetReceiveHandler

964357b

Fix MODULE.bazel dependency

bfe62c7

Fix test case

5a94417

Refactor control client test

6ba5340

Use StartFindService API

842e16a

Use mw::log macros

4a8decb

Extend integration test

59c9f3e

LmControlImpl rework and UT

9868b59

Drop component tests

ded0df1

Drop integration tests

636ba66

Remove connected flag

4cb0906

Service discovery

9cdc689

Do not stop service discovery

7414686

init refactoring

d5c0e35

event read refactoring

55d6cec

Refactor callback invocation

0539aa1

Remove LmControlServer

52ce0ba

github-project-automation Bot added this to LCM - Lifecycle & Health FT Aug 17, 2026

github-project-automation Bot moved this to Backlog in LCM - Lifecycle & Health FT Aug 17, 2026

NicolasFussberger deployed to workflow-approval August 17, 2026 09:18 — with GitHub Actions Active

Cleanup

faa5d86

NicolasFussberger force-pushed the feature/new_mw_com_based_api branch from 1c88cfc to faa5d86 Compare August 17, 2026 09:28

NicolasFussberger requested a deployment to workflow-approval August 17, 2026 09:28 — with GitHub Actions Waiting

Fix compiler warning and tsan failure

45bfd31

NicolasFussberger deployed to workflow-approval August 17, 2026 12:02 — with GitHub Actions Active

NicolasFussberger changed the title ~~mw::com based implementation of ilmcontrol interface~~ Initial mw::com-based implementation of ilmcontrol interface Aug 17, 2026

Cleanup

f335a05

NicolasFussberger requested a deployment to workflow-approval August 18, 2026 07:48 — with GitHub Actions Waiting

Fix test description

98e9a28

NicolasFussberger requested a deployment to workflow-approval August 18, 2026 08:02 — with GitHub Actions Waiting

NicolasFussberger requested a review from TimoSteuerwaldETAS August 18, 2026 08:03

NicolasFussberger marked this pull request as ready for review August 18, 2026 09:30

NicolasFussberger requested review from FScholPer, MaciejKaszynski, anmittag, antonkri, pawelrutkaq and ramceb as code owners August 18, 2026 09:30

anmittag assigned NicolasFussberger Aug 18, 2026

NicolasFussberger moved this from Backlog to In Progress in LCM - Lifecycle & Health FT Aug 18, 2026

danth mentioned this pull request Aug 18, 2026

Implement new control API #489

Draft

NicolasFussberger added 2 commits August 19, 2026 11:24

Merge remote-tracking branch 'upstream/main' into feature/new_mw_com_…

2db5298

…based_api

Downgrade to baselibs 0.2.10

78352dc

NicolasFussberger requested a deployment to workflow-approval August 19, 2026 09:33 — with GitHub Actions Waiting

danth reviewed Aug 19, 2026

View reviewed changes

MaciejKaszynski requested changes Aug 20, 2026

View reviewed changes

NicolasFussberger mentioned this pull request Aug 20, 2026

ControlClient: expose GetInitialMachineStateTransitionResult() and GetExecutionError() from ControlClientImpl to the public API #495

Open

TimoSteuerwaldETAS suggested changes Aug 20, 2026

View reviewed changes

Uh oh!

Conversation

NicolasFussberger commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions Bot commented Aug 17, 2026

Uh oh!

danth commented Aug 19, 2026

Uh oh!

NicolasFussberger commented Aug 19, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

NicolasFussberger commented Aug 17, 2026 •

edited

Loading

github-actions Bot commented Aug 17, 2026 •

edited

Loading