feat: add cr_checker - #2
Merged
AlexanderLanin merged 22 commits intoJul 21, 2026
Merged
Conversation
Fix copyright Fix reuse copyright findingds Fix linting
MaximilianSoerenPollak
requested review from
dcalavrezo-qorix and
nradakovic
as code owners
July 20, 2026 09:07
Now takes all inputs always so pre-commit & bazel behave the same
| # ******************************************************************************* | ||
| - id: copyright | ||
| name: Check and fix copyright headers with cr_checker | ||
| entry: cr_checker/tool/cr_checker.py --fix |
Contributor
Author
There was a problem hiding this comment.
Does it need the exclusion as well?
| @@ -0,0 +1,13 @@ | |||
| Copyright 2025 Contributors to the Eclipse Foundation | |||
Contributor
Author
There was a problem hiding this comment.
Remove? As the parent dir has one already?
| name = "score_tools" | ||
| ) | ||
| # CR_CHECKER | ||
| bazel_dep(name = "aspect_rules_py", version = "1.4.0") |
Contributor
Author
There was a problem hiding this comment.
See if this can be upgraded?
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
Re-reviewRe-reviewed after ✅ Both remaining bugs fixed
✅ Minor items also addressed
Verified locally: Verdict: All findings from prior reviews are resolved. Nothing blocking remains from my side. 👍 (Only nit left, non-blocking: |
AlexanderLanin
previously approved these changes
Jul 20, 2026
AlexanderLanin
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving
cr_checkerfrom the tooling repository.To start the splitting up process of the tooling repo.
This still has a dependency to tooling as
python_basicshas not been moved yet.This will be independed once that is done too.