ftp server: call logout callback on client timeout for consistency#372
Open
vb-linetco wants to merge 3 commits intoeclipse-threadx:devfrom
Open
Conversation
Otherwise this is not symmetric with the other case where logout is also called when the client disconnects. Refactor performing the logout into a separate helper to avoid duplication.
vb-linetco
force-pushed
the
feat/ftp-server-logout-callback-on-inactivity-timeout
branch
from
1d93c06 to
dcf5a11
Compare
Contributor
|
Thank you for this contribution @vb-linetco. I will review this soon. |
vb-linetco
commented
Mar 26, 2026
| /* 6.4.3 */ | ||
| /* AUTHOR */ | ||
| /* */ | ||
| /* TBD */ |
Author
There was a problem hiding this comment.
@fdesbiens Since I've only moved this code, I was not sure which Autor to put here. What is the policy about this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise this is not symmetric with the other case where logout is also called when the client disconnects.
Refactor performing the logout into a separate helper to avoid duplication.