feat: adding platform to scan card + some refactoring#1650
feat: adding platform to scan card + some refactoring#1650netomi merged 3 commits intoeclipse:masterfrom
Conversation
|
I’m using some styled versions of the components to avoid having duplicated styles throughout this component, and I’m also breaking it down into several smaller components. We could potentially move them to other files, but I think that for now having them here is fine. Now the main component sits at the end of the file and it’s far more clear what the purpose of it is. |
| sx={{ display: 'flex', alignItems: 'center', justifyContent: 'flex-end' }} | ||
| > | ||
| {showCheckbox && ( | ||
| <SelectionCheckbox |
There was a problem hiding this comment.
There doesn't seem to be a legend for this, and it doesn't seem super obvious what this would do without the code as context. Could I see a screenshot of this to get a better picture of how this appears in the scan card?
| onChange?: (checked: boolean) => void; | ||
| }> = ({ checked = false, onChange }) => { | ||
| const theme = useTheme(); | ||
| const [isHovering, setIsHovering] = useState(false); |
There was a problem hiding this comment.
question: You can't achieve hover styles with MUI's styled without using React state? I'm probably missing some context here, but it would be nice not to rely on React logic + event handlers for hover styles.
There was a problem hiding this comment.
I see this was introduced before this PR. Nevermind if this is out of scope.
…arams for extension admin page, fix lint errors, add changelog
netomi
left a comment
netomi
left a comment
There was a problem hiding this comment.
LGTM,
I did some minor changes:
- add links to the extension and extension admin page in the scan card for convenience
- fix lint error that were unrelated
- add changelog entry
4 participants
Resolves EclipseFdn/open-vsx.org#8201