material-renderers: Validation Icon on individual ExpandPanel, ListWithDetail items#2456
material-renderers: Validation Icon on individual ExpandPanel, ListWithDetail items#2456vishnutsivan wants to merge 1 commit intoeclipsesource:masterfrom
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
vishnutsivan
force-pushed
the
validation-icon
branch
from
1190bd3 to
ebcc4c1
Compare
vishnutsivan
changed the title
vishnutsivan
force-pushed
the
validation-icon
branch
from
ebcc4c1 to
fec759b
Compare
vishnutsivan
changed the title
|
Thanks for the contribution ❤️ This looks useful to me :) |
lucas-koehler
left a comment
lucas-koehler
left a comment
There was a problem hiding this comment.
Hi @vishnutsivan , thanks again for the contribution! The changes generally look reasonable to me and the feature is useful :)
I have one comment inline. Please have a look.
Also, for the validation icon in the master list item, there should be a little more space between the validation icon and the text. Furthermore, the validation icon should be vertically aligned with the text. I.e. see the screenshot below where the icon and text do not align and are very close together.
|
|
||
| export interface StatePropsOfMasterItem extends OwnPropsOfMasterListItem { | ||
| childLabel: string; | ||
| childErrors: string; |
There was a problem hiding this comment.
This should be the raw errors of type ErrorObject[] instead of the processed string for two reasons:
- To be consistent with the behavior of the array mapper in
mapStateToArrayControlProps - To allow renderers to decided for themselves how to show the errors.
lucas-koehler
force-pushed
the
master
branch
4 times, most recently
from
24c8cb2 to
d86047e
Compare
3 participants
Validation icons on individual List with details item
Validation icons on individual Expand panel item
