refactor(extractors): decouple extractors from common crate#1610
Merged
shiyasmohd merged 2 commits intomainfrom Jan 23, 2026
Merged
refactor(extractors): decouple extractors from common crate#1610shiyasmohd merged 2 commits intomainfrom
shiyasmohd merged 2 commits intomainfrom
Conversation
Contributor
LNSD
requested changes
Jan 22, 2026
Contributor
LNSD
left a comment
There was a problem hiding this comment.
The goal of this refactoring is to break the dependency on common, and the outcome should also add value in terms of organization.
Please check my comments. And check whether there are any other similar pieces of code that need to be moved into the "chain-specific" raw datasets modules.
As a rule of thumb:
- Specific to one extractor: keep it in the extractor crate.
- Common to different extractors (same chain technlogy, e.g., evm): Move it to
raw_datasets::evm::*. - Common to all extractors:
raw_datasets::<specific-module>::*(e.g., arrow helpers inraw_datasets::arrow::*). - Common to all datasets:
datasets_commoncrate.
7cc0713 to
fc1bb15
Compare
LNSD
reviewed
Jan 23, 2026
9a4c7b2 to
9420000
Compare
9420000 to
f8f645b
Compare
cmwhited
pushed a commit
that referenced
this pull request
Jan 23, 2026
* refactor(extractors): decouple extractors from common crate * refactor(datasets-raw): remove BoxError and BoxResult type aliases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove dependency on
commoncrate from all extractors (evm-rpc, firehose, solana)by moving shared types and utilities to
datasets-raw.Changes:
blocks.rs,logs.rs) fromcommontodatasets-rawarrow_helpers.rswith array builders todatasets-rawprovider.rsfromcommontoevm-rpcextractorBoxError,Bytes32,EvmAddress, etc.) todatasets-rawdatasets-rawinstead ofcommonCargo.toml