refactor(extractors): use provider config types from providers crates#1748
Merged
refactor(extractors): use provider config types from providers crates#1748
Conversation
LNSD
force-pushed
the
lnsd/refactor-extractors-provider-config
branch
from
5c3671b to
dfe784d
Compare
LNSD
force-pushed
the
lnsd/refactor-extractors-provider-config
branch
from
dfe784d to
f53ab76
Compare
shiyasmohd
approved these changes
Feb 13, 2026
Contributor
shiyasmohd
left a comment
shiyasmohd
left a comment
There was a problem hiding this comment.
LGTM ✅
Added comments for small nits.
Also serde crate is not used in amp-providers-registry crate. Can be removed.
Remove duplicated ProviderConfig structs from extractor crates and use canonical types from amp-providers-* crates instead. - Replace extractor-local `ProviderConfig` with `EvmRpcProviderConfig`, `FirehoseProviderConfig`, and `SolanaProviderConfig` - Add `Redacted::into_inner()` to unwrap redacted URLs and tokens from provider configs - Unify `NetworkId::PartialEq` with generic `AsRef<str>` impl and add `new_unchecked` constructor - Remove `serde_with` dependency from extractor crates now that config parsing lives in providers Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
LNSD
force-pushed
the
lnsd/refactor-extractors-provider-config
branch
from
f53ab76 to
9249137
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove duplicated
ProviderConfigstructs from extractor crates and use canonical types fromamp-providers-*crates instead.ProviderConfigwithEvmRpcProviderConfig,FirehoseProviderConfig, andSolanaProviderConfigRedacted::into_inner()to unwrap redacted URLs and tokens from provider configsNetworkId::PartialEqwith genericAsRef<str>impl and addnew_uncheckedconstructorserde_withdependency from extractor crates now that config parsing lives in providers