Skip to content

feat(admin-api): add get revision by location ID endpoint#1753

Merged
shiyasmohd merged 1 commit intomainfrom
shiyasmohd/get-revision-by-id
Feb 14, 2026
Merged

feat(admin-api): add get revision by location ID endpoint#1753
shiyasmohd merged 1 commit intomainfrom
shiyasmohd/get-revision-by-id

Conversation

@shiyasmohd
Copy link
Contributor

@shiyasmohd shiyasmohd commented Feb 13, 2026

  • Add GET /revisions/{id} to retrieve a single physical table revision by its location ID, including path, active status, writer, and metadata.
  • Add integration tests for success, not-found, deactivation, and invalid ID cases

Example Output

{
  "id": 1,
  "path": "mainnet/blocks/019c55a7-df24-7ca1-b990-1054b7a3f437",
  "active": true,
  "writer": 1,
  "metadata": {
    "dataset_namespace": "edgeandnode",
    "dataset_name": "mainnet",
    "manifest_hash": "3653ba10dced7e02241c92d921e7ec94b587d9c1718839588cbb88fee8e9f2b1",
    "table_name": "blocks"
  }
}

@shiyasmohd shiyasmohd self-assigned this Feb 13, 2026
@shiyasmohd shiyasmohd force-pushed the shiyasmohd/get-revision-by-id branch 2 times, most recently from 73dfa63 to 7274c88 Compare February 13, 2026 05:30
@shiyasmohd shiyasmohd requested a review from LNSD February 13, 2026 05:37
@shiyasmohd shiyasmohd force-pushed the shiyasmohd/get-revision-by-id branch from 7274c88 to 4de861f Compare February 13, 2026 06:04
Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the docs/features/admin-revisions.md document to document this new functionality. And also, update ampctl (and the Admin Client) to support these changes.

I leave the decision of where to implement those to you. Either in this PR or in a follow-up PR.

@shiyasmohd shiyasmohd force-pushed the shiyasmohd/get-revision-by-id branch from 4de861f to 83bde19 Compare February 14, 2026 04:46
@shiyasmohd shiyasmohd force-pushed the shiyasmohd/get-revision-by-id branch from 83bde19 to 28364bc Compare February 14, 2026 04:55
@shiyasmohd
Copy link
Contributor Author

All comments addressed in 28364bc

@shiyasmohd shiyasmohd merged commit 11b5e74 into main Feb 14, 2026
7 checks passed
@shiyasmohd shiyasmohd deleted the shiyasmohd/get-revision-by-id branch February 14, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants