Skip to content

refactor(tests): rewrite dump tests to compare via flight sql queries#1754

Merged
shiyasmohd merged 1 commit intomainfrom
shiyasmohd/fix-dump-tests
Feb 17, 2026
Merged

refactor(tests): rewrite dump tests to compare via flight sql queries#1754
shiyasmohd merged 1 commit intomainfrom
shiyasmohd/fix-dump-tests

Conversation

@shiyasmohd
Copy link
Contributor

@shiyasmohd shiyasmohd commented Feb 13, 2026

Summary

  • Replace SnapshotContext-based comparison with direct Flight SQL query comparison.
  • Remove unused SnapshotContext fixture and snapshot helper functions.
  • Refresh base_rpc snapshot data.

Note:
Before this PR we were comparing same data in assert for it_dump.rs. Since now we have physical table revision management APIs via admin-api after restoring snapshot, we deactivate those tables and then deploy new dataset. Through this we are now dumping fresh data. During testing, found a bug on base_rpc snapshot. request_hash field in blocks table was not found in snapshot. Updated the base_rpc snapshot with fresh data now. Also found outdated data on eth_firehose & base_firehose datasets. Updated them with new snapshots too.

Closes #1662

@shiyasmohd shiyasmohd self-assigned this Feb 13, 2026
@shiyasmohd shiyasmohd requested a review from LNSD February 13, 2026 11:17
@shiyasmohd shiyasmohd force-pushed the shiyasmohd/fix-dump-tests branch 3 times, most recently from 247ee99 to 4afcb7c Compare February 16, 2026 05:42
Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Only one minor detail.

@shiyasmohd shiyasmohd force-pushed the shiyasmohd/fix-dump-tests branch from 4afcb7c to fc565bb Compare February 17, 2026 07:50
@shiyasmohd shiyasmohd merged commit d723cd6 into main Feb 17, 2026
7 checks passed
@shiyasmohd shiyasmohd deleted the shiyasmohd/fix-dump-tests branch February 17, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace in-process SnapshotContext with ampctl revision management in testlib

2 participants