fix(common): visit scalar subqueries when attaching plans#1756
Merged
Conversation
Fixes panic when queries contain scalar subqueries in expressions (e.g., LEAST((SELECT MAX(...)), (SELECT MAX(...)))). The bug: DetachedLogicalPlan::attach_to() used transform() which only visits direct plan children, leaving PlanningTable providers unvisited inside scalar subquery expressions. This caused panics during physical planning when PlanningTable::scan() was called. The fix: Use transform_with_subqueries() to visit all LogicalPlan nodes including those embedded in expressions.
Theodus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes panic when queries contain scalar subqueries in expressions (e.g.,
LEAST((SELECT MAX(...)), (SELECT MAX(...)))).The bug: DetachedLogicalPlan::attach_to() used transform() which only visits direct plan children, leaving PlanningTable providers unvisited inside scalar subquery expressions. This caused panics during physical planning when PlanningTable::scan() was called.
The fix: Use transform_with_subqueries() to visit all LogicalPlan nodes including those embedded in expressions.