fix: reject operations on closed transaction handles - #1062
Merged
tdrz merged 1 commit intoJul 28, 2026
Conversation
psh4607
marked this pull request as ready for review
July 20, 2026 07:44
tdrz
self-requested a review
July 28, 2026 08:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Retained transaction handles can currently execute queries after their transaction has ended.
tx.sqlskips the closed-handle guard, and the automatic rollback path for a rejected callback leaves the handle marked open. Subsequent operations then run against the live auto-commit connection, allowing writes that callers expect to have been rolled back to persist.Related issue
Fixes #1049
Changes
checkClosed()before executingtx.sql.@electric-sql/pglite.Tests
pnpm --dir packages/pglite buildpnpm --dir packages/pglite typecheckpnpm --dir packages/pglite stylecheckpnpm --dir packages/pglite test(283 passed, 1 skipped)