Remove reference to PostgresMod for long-running processes - #1073
Open
jdunck wants to merge 1 commit into
Open
Conversation
jdunck
commented
Aug 3, 2026
| * Throws if the module is not yet loaded, or has been released by `close()` - | ||
| * the Emscripten runtime is force-exited on close and cannot be revived. | ||
| */ | ||
| protected get mod(): PostgresMod { |
jdunck
commented
Aug 3, 2026
| // force-exited above and cannot be revived, so holding on to it only | ||
| // pins its heap (which can be hundreds of MB) for as long as this | ||
| // instance is referenced. Any later access throws via the `mod` getter. | ||
| this._mod = undefined |
Author
There was a problem hiding this comment.
This is the motivation for the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a long-running process using many instances of pglite, we noticed that heap is never being freed. I believe this may be because
.modis holding a reference to the pg emscripten module.I hope you'll agree this should be a safe change to make.
Around 14:45, there was a major GC but you can see no dropoff for the external space.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.