Skip to content

ci: bump electron/semantic-trusted-release to v1.1.2 - #394

Merged
MarshallOfSound merged 2 commits into
mainfrom
ci/semantic-trusted-release-v1.1.1
Oct 22, 2026
Merged

MarshallOfSound merged 2 commits into
mainfrom
ci/semantic-trusted-release-v1.1.1

Conversation

@claude

@claude claude Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Requested by Keeley Hammond · Slack thread

The release action pinned here ran the npm publish step on Node 24.10.0, which predates the October 2026 Node.js security release. v1.1.2 tracks the latest Node 24.x via check-latest, so future Node patch releases need no further pin bumps.


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EvByZWibvh3yPk8R9FdxyN
@claude
claude Bot requested a review from a team as a code owner October 22, 2026 04:10
@claude

claude Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

CI note: Test (43, 22.23.4, ubuntu-latest) failed (and required-ci with it, since it only aggregates the matrix).

Root cause: the flaky spec Devtron Installation > should load the extension in newly created sessions (spec/devtron-install-spec.ts:107) got false. It checks newSes.extensions.getAllExtensions() synchronously right after session.fromPartition(...). In this run the Devtron service worker needed a retry ("Failed to start Devtron service-worker ... trying again"), so the extension wasn't loaded into the new session yet. The other 22 specs and the rest of the matrix passed.

Unrelated to this PR: the only change here is the pinned SHA in .github/workflows/release.yml, which runs on release/push and not in the Test workflow. The same job passed on main's latest push at the same base commit (https://github.com/electron/devtron/actions/runs/39691399581/job/119538188925). The same spec also failed intermittently on an unrelated Dependabot PR (https://github.com/electron/devtron/actions/runs/37498976034/job/112390749115).

Fix: none exists yet. Re-running the failed job should clear it. A lasting fix would be for the spec to wait for or poll the extension load instead of asserting synchronously.


Generated by Claude Code

@MarshallOfSound
MarshallOfSound enabled auto-merge (squash) October 22, 2026 05:02
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EvByZWibvh3yPk8R9FdxyN
@claude claude Bot changed the title ci: bump electron/semantic-trusted-release to v1.1.1 ci: bump electron/semantic-trusted-release to v1.1.2 Oct 22, 2026
@MarshallOfSound
MarshallOfSound merged commit 38a043c into main Oct 22, 2026
57 of 59 checks passed
@MarshallOfSound
MarshallOfSound deleted the ci/semantic-trusted-release-v1.1.1 branch October 22, 2026 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants