Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on: |
Member
Author
|
@SocketSecurity ignore npm/[email protected] Looks like Vite/Vitest forked the old |
erikian
approved these changes
Dec 5, 2025
Co-authored-by: Erik Moura <[email protected]>
Co-authored-by: Erik Moura <[email protected]>
erikian
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-requisite for some of the Node 22 work in #4059 because of some
import.meta.resolveimplementation issues with Vitest that were fixed upstream.This PR:
yarn up.import.meta.resolvefix). I needed to add an exception to the Yarn Constraints for the time being.vitest.workspace.mtsto theprojectskey invitest.config.mts.PublisherS3.spec.tsto usevi.importActual, since applyingvi.mock('node:fs')in Vitest 4 actually mocks out the fixture code too.