Plan sources before creating plan_subquery closure#4548
Merged
greg-rychlewski merged 1 commit intoelixir-ecto:masterfrom Nov 12, 2024
Merged
Plan sources before creating plan_subquery closure#4548greg-rychlewski merged 1 commit intoelixir-ecto:masterfrom
greg-rychlewski merged 1 commit intoelixir-ecto:masterfrom
Conversation
josevalim
approved these changes
Nov 12, 2024
Member
josevalim
left a comment
josevalim
left a comment
There was a problem hiding this comment.
Thank you for cleaning up after me ❤️
greg-rychlewski
changed the title
dkuku
pushed a commit
to dkuku/ecto
that referenced
this pull request
Dec 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4547
Because
whereand friends might need to cast parameters to field types, we need to be able to plan the sources first. This wayquery.sourcesis populated.