Skip to content

Use after_verify callback and reduce compile-time work #4552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
josevalim merged 6 commits into from
Nov 28, 2024
Merged

Use after_verify callback and reduce compile-time work #4552

josevalim merged 6 commits into from
Nov 28, 2024

Conversation

@josevalim
Copy link
Member

@josevalim josevalim commented Nov 28, 2024 •
edited
Loading

Closes #4293.

@josevalim josevalim mentioned this pull request Nov 28, 2024
Closed
@josevalim josevalim changed the title Use after_verify callback, closes #4293 Use after_verify callback and reduce compile-time work, closes #4293 Nov 28, 2024
@josevalim josevalim changed the title Use after_verify callback and reduce compile-time work, closes #4293 Use after_verify callback and reduce compile-time work Nov 28, 2024
@josevalim josevalim merged commit c0203db into master Nov 28, 2024
6 checks passed
@josevalim
Copy link
Member Author

josevalim commented Nov 28, 2024

💚 💙 💜 💛 ❤️

@josevalim josevalim deleted the jv-after-verify branch November 28, 2024 21:23
@warmwaffles
Copy link
Member

warmwaffles commented Nov 29, 2024

Awesome, I was wondering when this bug was going to irritate someone enough to get it fixed. 🤣

@josevalim
Copy link
Member Author

josevalim commented Nov 29, 2024

It is more that I wanted to avoid bumping the Elixir requirement, and I would prefer to have a reproduction. :) but 1.14 is the minimum supported version anyway, so we are good. :)

dkuku pushed a commit to dkuku/ecto that referenced this pull request Dec 14, 2024
@josevalim @dkuku
Use after_verify callback and reduce compile-time work (elixir-ecto#4552
b463657 
)

Closes elixir-ecto#4293.
Kasse-Dembele added a commit to UbloImmo/ecto that referenced this pull request Mar 24, 2025
@Kasse-Dembele
fix: ecto playing russian roulette with compiler (see elixir-ecto/pul…
a1b25f6 
…l/4552/files)
Kasse-Dembele added a commit to UbloImmo/ecto that referenced this pull request Mar 26, 2025
@Kasse-Dembele
fix: ecto playing russian roulette with compiler (see elixir-ecto/pul…
bfac5c5 
…l/4552/files)
Kasse-Dembele added a commit to UbloImmo/ecto that referenced this pull request Mar 26, 2025
@Kasse-Dembele
fix: ecto playing russian roulette with compiler (see elixir-ecto/pul…
17c7cbc 
…l/4552/files)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Intermittent "invalid association" warnings at compile time

3 participants

@josevalim @warmwaffles