feat: add telemetry event emission for repo process start#4702
Closed
yordis wants to merge 1 commit intoelixir-ecto:masterfrom
Closed
feat: add telemetry event emission for repo process start#4702yordis wants to merge 1 commit intoelixir-ecto:masterfrom
yordis wants to merge 1 commit intoelixir-ecto:masterfrom
Conversation
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
yordis/telemetry-started
branch
from
4fc43fd to
e911bf6
Compare
Contributor
Author
|
@whatyouhide 👋🏻 related to the 1+ you gave me in the OTEL pkg, any thoughts on this one? |
Contributor
Author
|
🤦🏻 I just realized that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to open-telemetry/opentelemetry-erlang-contrib#332
Some folks shared that it is not always "safe" to do what I proposed there. With this new telemetry event, we could add auto-instrumentation. Ideally, reducing the friction, forgetting to wire new repos, and have similar experience to other auto-instr ecosystems