Fix File.open/2 and variants specs to accept :directory option - #15890
Open
aiotter wants to merge 3 commits into
Open
Fix File.open/2 and variants specs to accept :directory option#15890aiotter wants to merge 3 commits into
File.open/2 and variants specs to accept :directory option#15890aiotter wants to merge 3 commits into
Conversation
josevalim
reviewed
Sep 13, 2026
josevalim
reviewed
Sep 13, 2026
Co-authored-by: José Valim <jose.valim@gmail.com>
Member
|
@aiotter thank you! Can you please add a unit test to file_test.exs that opens up a directory? The dialyzer tests were not needed, since they were just duplicating the implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File.open/2forwards:directoryoption to:file.open/2, which has supported it since OTP 23.However, the option was missing from the specs, causing Dialyzer to reject valid calls.
This PR adds
:directoryoption to the specs ofFile.open/2and its variants.It also adds a regression test.