feat: halt system on significant child process failure#485
Open
Draggu wants to merge 1 commit intoelixir-lang:mainfrom
Open
feat: halt system on significant child process failure#485Draggu wants to merge 1 commit intoelixir-lang:mainfrom
Draggu wants to merge 1 commit intoelixir-lang:mainfrom
Conversation
mhanberg
reviewed
Mar 4, 2026
mkaput
reviewed
Mar 5, 2026
Member
|
testing this today |
mhanberg
reviewed
Mar 19, 2026
Member
mhanberg
left a comment
mhanberg
left a comment
There was a problem hiding this comment.
In testing this, I may have found a bug in the neovim lsp client. when you close it, it seems to send the shutdown request multiple times (which we handle gracefully, but was pretty confusing when encountering).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gen_lsppart elixir-tools/gen_lsp#80Close #428, I tried to fix the source problem here (writing to stdout), but I'm not sure if case I found is the only one. I don't think there exists a valid restart option since clients can't recover from gibberish written to output.