Repository navigation
feat!: add support for Hackney 4.x, drop Elixir <1.17 and OTP <26 - #839
Merged
Merged
Conversation
phinnaeus
changed the title
phinnaeus
force-pushed
the
hackney-4-upgrade
branch
3 times, most recently
from
June 26, 2026 22:40
94d2c80 to
ff6d120
Compare
phinnaeus
force-pushed
the
hackney-4-upgrade
branch
from
June 26, 2026 23:36
ff6d120 to
fe2b710
Compare
Contributor
Author
|
Finally got CI passing on my fork https://github.com/phinnaeus/wallaby/actions/runs/28271223452 Had to bump Credo in order to run the linting step on Elixir 1.20, which in turn required a few extra code changes. |
phinnaeus
force-pushed
the
hackney-4-upgrade
branch
2 times, most recently
from
June 27, 2026 02:06
c02862d to
a9e360c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that web_driver_client 0.3.0 is released, we can combine that and httpoison 3.0.0 to make a version of wallaby that is compatible with hackney 4.x.
Hackney 4.x requires OTP 26+ and web_driver_client 0.3.0 requires Elixir 1.17 so I bumped those as well.
I have tested this with my own phoenix project locally that uses wallaby for feature testing and verified I can fully upgrade to hackney 4.x and my feature tests still work.
This is nice because I can finally remove the ignore rules for the four CVEs that were fixed in Hackney 4.0.1+: