Swap the hand-rolled API mirror for the SDK 0.8.1 generated client - #110
Merged
Conversation
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 0bdafb3 in 8 minutes, 56 seconds.
- Reviewed
1commit with2121lines of code in38files - Ran
1review agent producing0comments where0were posted - This pipeline runs no gatekeeper, so findings are posted as written.
- View full details on ellipsis.dev
This review was created by . You can tag
@ellipsis in this pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Replaces the hand-rolled API client with the SDK 0.8.1 generated client, delegating all REST operations to the SDK rather than maintaining a parallel mirror of the API surface.
ApiClientclass is removed fromsrc/lib/api.tsand replaced with anapi()function that returns an Ellipsis SDK client instance. All 20+ command files now callapi().analytics.metrics(),api().agents.configs.list(),api().files.get(), etc. instead of instantiating and calling methods on ApiClient.src/lib/types.ts. Types now come from the SDK-generated schema (@ellipsis-dev/sdk), re-exported under CLI-specific names to catch API renames as type errors rather than silent undefined fields.APIErrorclass instead of the customApiError. AddederrorDetail()anddescribeApiError()helpers to extract the server's message and request ID from SDK errors for terminal output.@ellipsis-dev/sdkbumped from 0.6.0 to 0.8.1 in package.json and bun.lock.This description was created by
for 0bdafb3. It will automatically update as commits are pushed.