Skip to content

fix: disable systemRouter when not using .listen() to prevent perform… #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SimoHypers wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: disable systemRouter when not using .listen() to prevent perform… #1611

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ export default class Elysia<
}
> {
config: ElysiaConfig<BasePath>

_isListening = false
server: Server | null = null
private dependencies: { [key: string]: Checksum[] } = {}

Expand Down Expand Up @@ -8016,10 +8016,20 @@ export default class Elysia<
*
* Beside benchmark purpose, please use 'handle' instead.
*/

private _compiledFetch?: (request: Request) => MaybePromise<Response>
fetch = (request: Request): MaybePromise<Response> => {
return (this.fetch = this.config.aot
? composeGeneralHandler(this)
: createDynamicHandler(this))(request)
if (!this._compiledFetch) {
if (!this._isListening && this.config.systemRouter) {
this.config.systemRouter = false
}

this._compiledFetch = this.config.aot
? composeGeneralHandler(this)
: createDynamicHandler(this)
}

return this._compiledFetch!(request)
}

/**
Expand Down Expand Up @@ -8074,6 +8084,7 @@ export default class Elysia<
options: string | number | Partial<Serve>,
callback?: ListenCallback
) => {
this._isListening = true
this['~adapter'].listen(this)(options, callback)

return this
Expand Down