Initial OpenMP support #25937
Initial OpenMP support #25937
Conversation
|
To clarify, I have tested this by compiling + linking a program requiring openmp |
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
I assume the contents of system/lib/libomp is coming from an upstream repo?
Can you using git submodule for this and put it in third_party/ maybe?
tools/settings.py
Outdated
| @@ -431,4 +432,4 @@ def restore(self, previous): | |||
| self.attrs.update(previous) | |||
|
|
|||
|
|
|||
| settings = SettingsManager() | |||
| settings = SettingsManager() | |||
There was a problem hiding this comment.
Looks like the final newline here got deleted?
There was a problem hiding this comment.
I just added an extra newline in the latest commit. I an not sure why github thinks the file is 435 lines long
Yess, it is from llvm. Since all the other llvm libraries are in this location, it made sense to put it here. Do you want the entire LLVM repository as a submodule? It seems a bit overkill, at that point the other libraries can also be pulled from there |
Oh i see, I didn't realize this was from llvm. I that case the import approach your took does seem reasonable. |
2 participants
This makes
emccrecognize-fopenmp, and links it as needed.When updating openmp, it neesd to be compiled. This is not strictly neccesary, but we need to invoke cmake in order to generate the headers. When compiling openemp, we need to make use of cmake as well, as the build system is quite long and complicated. I am sure it can be done another way using ninja, and I encourage others to implement this, but I do not have the capacity right now to make this happen.
Fixes: #13892