Add extended-const to feature matrix and pass to wasm-ld - #27532
Open
sbc100 wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
Of course, because this is the first time we are really enabling this we ran into an llvm isse: llvm/llvm-project#215929 |
sbc100
force-pushed
the
extended-const-feature-matrix
branch
from
August 14, 2026 01:06
dbc2de5 to
4b44b31
Compare
Add `Feature.EXTENDED_CONST` to `tools/feature_matrix.py` with minimum supported engine versions (Chrome 114, Firefox 112, Safari 17.4, Node 21.0.0). Also handle `-mextended-const` and `-mno-extended-const` flags in `tools/cmdline.py`, and pass `--extra-features=extended-const` to `wasm-ld` in `tools/building.py` when `extended-const` is available. Even though this feature is not enabled by out default browser versions this change does enable this feature automatically when opting into other newer features such as MEMORY64 or WASM_EXCEPTIONS.
sbc100
force-pushed
the
extended-const-feature-matrix
branch
from
August 14, 2026 05:23
4b44b31 to
1683bff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Feature.EXTENDED_CONSTtotools/feature_matrix.pywith minimum supported engine versions (Chrome 114, Firefox 112, Safari 17.4, Node 21.0.0).Also handle
-mextended-constand-mno-extended-constflags intools/cmdline.py, and pass--extra-features=extended-consttowasm-ldintools/building.pywhenextended-constis available.Even though this feature is not enabled by our default browser versions this change does enable this feature automatically when opting into other newer features such as MEMORY64 or WASM_EXCEPTIONS.