Fix stale requestFileHandles() call in Cross-Origin Storage docs - #27585
Merged
Conversation
The instantiateWasm example called requestFileHandles(cosHash) with a bare hash and then treated the result as a single FileSystemFileHandle. The API is requestFileHandle() (singular), as already used elsewhere in this document and in src/preamble.js.
sbc100
approved these changes
Aug 21, 2026
sbc100
enabled auto-merge (squash)
August 21, 2026 19:41
sbc100
disabled auto-merge
August 21, 2026 19:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
instantiateWasmexample insite/source/docs/compiling/CrossOriginStorage.rstcallednavigator.crossOriginStorage.requestFileHandles(cosHash)with a bare hash and then treated the result as a singleFileSystemFileHandle(.then(handle => handle.getFile())).The API is
requestFileHandle()(singular). The plural form was an early draft that took an array of hashes and returned an array of handles; it was removed in favor of the singular form. The rest of this document — and the actual implementation insrc/preamble.js— already use the singular form, so this example was the only stale call site.Docs-only, one line.