[test] Fix error reporting and revert key events in test_glfw_events.c - #27597
Merged
Conversation
In emscripten-core#22915 I inadvertently broke this test but it went unnoticed because the error reporting was broken. This change reverts `test_glfw_events.c` to use `injectKeyEvent` via `EM_ASM` instead of trying to use `fake_events.js` (which is not flexible enough yet for this test). Also fix the error reporting and add `test_success` and `test_fail` helpers the help keep it simple.
sbc100
force-pushed
the
fix_test_glfw_events
branch
from
August 22, 2026 22:57
688ea17 to
80a689b
Compare
kripken
approved these changes
Aug 24, 2026
sbc100
added a commit
that referenced
this pull request
Aug 25, 2026
Replace manual `g_state` bitmask failure tracking with direct `assert()` checks in callbacks and the test runner loop. Followup to #27597
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #22915 I inadvertently broke this test but it went unnoticed because
the error reporting was broken.
This change reverts
test_glfw_events.cto useinjectKeyEventviaEM_ASMinstead of trying to usefake_events.js(which is not flexibleenough yet for this test).
Also fix the error reporting and add
test_successandtest_failhelpers the help keep it simple.