Add test for native AudioWorklet.port and @requires_chrome_version - #27679
Merged
Merged
Conversation
sbc100
force-pushed
the
test-audioworklet-port
branch
2 times, most recently
from
September 5, 2026 16:39
54c5af5 to
12a86f4
Compare
Add `--enable-blink-features=AudioWorkletSharedPort` to Chrome default flags to enable `AudioWorklet.port` (the spec-defined shared `MessagePort` between `AudioWorklet` and `AudioWorkletGlobalScope`). Add `get_chrome_version()` in `test/browser_common.py` and `requires_chrome_version` in `test/test_browser.py`. Add `test/webaudio/test_audio_worklet_port.c` and test `test_audio_worklet_port` to verify that when native `AudioWorklet.port` is present, the worklet uses it directly without falling back to the `em-bootstrap` `AudioWorkletProcessor`. See: emscripten-core#27615
sbc100
force-pushed
the
test-audioworklet-port
branch
from
September 15, 2026 17:26
12a86f4 to
3bf6302
Compare
sbc100
enabled auto-merge (squash)
September 15, 2026 20:13
kripken
reviewed
Sep 16, 2026
| # this flag for now: https://crbug.com/638180 | ||
| '--no-first-run -start-maximized --no-sandbox --enable-unsafe-swiftshader --use-gl=swiftshader --enable-features=JavaScriptSourcePhaseImports', | ||
| '--enable-experimental-webassembly-features', | ||
| '--enable-blink-features=AudioWorkletSharedPort', |
Member
There was a problem hiding this comment.
In general, do we want to enable such things for all tests? Can we enable it just for the one new test?
Collaborator
Author
There was a problem hiding this comment.
We don't currently have any mechanism by which to do that. We re-uses the same browser process across tests, so they don't get their own argument.
We already do --enable-experimental-webassembly-features just above so there is precedent for doing this.
kripken
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
--enable-blink-features=AudioWorkletSharedPortto Chrome default flags to enableAudioWorklet.port(the spec-defined sharedMessagePortbetweenAudioWorkletandAudioWorkletGlobalScope).Add
get_chrome_version()intest/browser_common.pyandrequires_chrome_versionintest/test_browser.py.Add
test/webaudio/test_audio_worklet_port.cand testtest_audio_worklet_portto verify that when nativeAudioWorklet.portis present, the worklet uses it directly without falling back to theem-bootstrapAudioWorkletProcessor.See: #27615