NODERAWSOCKETS: report the source address from getsockname() right after connect() - #27688
Merged
guybedford merged 1 commit intoSep 16, 2026
Merged
Conversation
Collaborator
Author
|
//cc @brendandahl if you have a moment to review this one it would be much appreciated. |
sbc100
reviewed
Sep 14, 2026
guybedford
force-pushed
the
noderawsockets-connect-saddr
branch
from
September 16, 2026 05:56
0bac26c to
291dead
Compare
sbc100
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes
getsockname()afterconnect()to store the address immediately, so that it can be returned in host calls, which was an oversight missed from #27566.This is Node.js 26+ only for now for that immediate connect behavior, although a 24 backport of that Node.js feature may be coming as well.