Skip to content

Fix flakiness in test_pthread_dylink_tls_free #28120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Oct 31, 2026
Merged

Fix flakiness in test_pthread_dylink_tls_free #28120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions test/core/pthread/test_pthread_dylink_tls_free.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,11 @@ int main() {

// Each thread allocates the side module's 4 KiB TLS block on first access and
// must free it when it exits. Without the fix the heap grows by one block
// per thread; with it, growth is bounded by the last thread's not-yet-
// reclaimed stack, far below NUM_THREADS blocks. NUM_THREADS is large so a
// real leak clearly exceeds that fixed slack.
// per thread. This runs on the main runtime thread (no PROXY_TO_PTHREAD) so
// that pthread_join() frees the joined thread's own block (stack, TLS,
// pthread struct) synchronously. From a pthread that free happens later on
// the main thread, which can fall several joins behind and make the
// measurement depend on timing.
run_threads(10);
size_t before = mallinfo().uordblks;
run_threads(NUM_THREADS);
Expand Down
1 change: 0 additions & 1 deletion test/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9449,7 +9449,6 @@ def test_pthread_dylink_tls_free(self):

self.prep_dlfcn_main()
self.set_setting('EXIT_RUNTIME')
self.set_setting('PROXY_TO_PTHREAD')
self.do_runf('core/pthread/test_pthread_dylink_tls_free.c', 'done\n')

@needs_dylink
Expand Down
Loading