GCC: Fix "Instruction count mismatch" when combining text sections - #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When combining GCC text sections grouped by "." separators was implemented, the logic in
symbol_sectionwas not updated to take this into account, which introduced issues where symbols would fail to be paired up when sections were merged on one side but not the other (which could happen when only one side only had a single text section and didn't need to be combined). This also results in an "Instruction count mismatch" error due to the symbols not being paired up properly (fixes #374).I factored out the duplicate logic to a shared function so it's always consistent.