Conversation
Added hint for buoy in the combat section, as well as hint for defeated animation for the sequence puzzle section.
Added some hint to incomplete character
|
Play this branch at https://play.threadbare.game/branches/endlessm/Champ_standardize_hint. (This launches the game from the start, not directly at the change(s) in this pull request.) |
felixwalberg
approved these changes
Feb 20, 2026
Contributor
felixwalberg
left a comment
felixwalberg
left a comment
There was a problem hiding this comment.
Definitely more clear for the learners!
| ~ well_done | ||
| Evan has fed whatever swims below the dark surface of the lake, but he only got a glimpse of something he thought looked green and scaly. | ||
| It swims so fast! He must push forward to keep up. | ||
| He believe if those buoy had been more flamboyant and bold in their color, the thing that lurked beneath might have been more attracted. |
Contributor
There was a problem hiding this comment.
There might be a tiny conflict with #1950, but it will be an easy fix as it's just dialogue text.
wjt
reviewed
Feb 23, 2026
| ## Function to remove collisions, allowing the player to walk on water tiles | ||
| func _walk_on_water() -> void: | ||
| #remove the collision of the Water_border, allowing player to "walk" on "water" | ||
| $"../TileMapLayers/Water_border".enabled = false |
Member
There was a problem hiding this comment.
In general, $../ is an anti-pattern. If there are nodes elsewhere in the scene that this script wants to reference, it should have an @export and you should assign the nodes in the inspector.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in Issue #1925, we needed some more hint, as well as standardizing hint as a whole. I believe keeping some hint in game is useful,(in conjunction with in code TODO and hint) as it allow player to get a good idea of what they need to change on their first playthrough, instead of having to play the game, and then find out on their own what problem exist.