Remove optional https from imageUrl regex

[joejstuart]

Remove this option from the imageUrl. As it adds no value to the user and just complicates things.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.55%. Comparing base (dc6f579) to head (e232de5).

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #484   +/-   ##
=====================================
  Coverage   0.55%   0.55%           
=====================================
  Files          6       6           
  Lines        363     363           
=====================================
  Hits           2       2           
  Misses       361     361           

Flag	Coverage Δ
api	0.64% <ø> (ø)
controller	0.00% <ø> (ø)
schema	0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
api/v1alpha1/enterprisecontractpolicy_types.go	100.00% <ø> (ø)

[simonbaird]

Will this break people who do have the https in their urls?

[simonbaird]

What's the motivation? Just because it's useless?

[simonbaird]

@joejstuart I guess my questions are still relevant. FWIW I'm not against merging this if we're confident it won't break anyone.

[joejstuart]

What's the motivation? Just because it's useless?

I completely forgot about this. Yes, it's useless and we're using the component.ConainerImage in ec-cli which does not have the https so it would add more work for us if someone did use the protocol. And nobody is using the feature yet, so we're safe to change it.

[simonbaird]

Rebase needed?

[Acepresso]

LGTM. Don't forget to rebase so we have the corresponding unit-test verify this change.

[robnester-rh]

LGTM