Set autoescape for Jinja templates #42672
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autoescape protects web applications against most common cross-site-scripting (XSS) vulnerabilities. While the output from Jinja templates in the Kafka module don't generate HTML, enabling autoescape for HTML/XML avoids tripping automatic security scanners. Signed-off-by: Dina Di <[email protected]>
|
Hi @dinaweiwendi, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
Member
|
sorry could you clarify on exactly what do you want to achieve with this? These configs are harmless but not used by Envoy binary in practice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autoescape protects web applications against most common cross-site-scripting (XSS) vulnerabilities.
While the output from Jinja templates in the Kafka module don't generate HTML, enabling autoescape for HTML/XML avoids tripping automatic security scanners.
Commit Message: Autoescape protects web applications against most common cross-site-scripting (XSS) vulnerabilities.
While the output from Jinja templates in the Kafka module don't generate HTML, enabling autoescape for HTML/XML avoids tripping automatic security scanners.
Additional Description: Related pr #38711
Risk Level: low
Testing: n/a, "Tests will automatically run for you."
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]