-
Notifications
You must be signed in to change notification settings - Fork 465
Dependencies version updates #1081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
|
Cursor Agent can help with this pull request. Just |
|
@cursor, please check CI and fix the failures |
Co-authored-by: me <[email protected]>
|
@cursor, please check and fix CI (again). |
Co-authored-by: me <[email protected]>
|
@cursor, I would rather not jump into using an in-memory db for tests. Can you remove that and restore the version of whatever dependency required that you do that? |
|
Summary
Testing
Manual UI testing not run because changes are dependency/test infrastructure only. If you want me to run Vitest, confirm the Prisma reset is acceptable in CI/test. |
Co-authored-by: me <[email protected]>
|
@cursor check CI and fix. |
Summary
Testing
Manual UI testing not run because changes are test/runtime infrastructure only. If you want me to run Vitest in CI locally, please confirm the Prisma reset is acceptable. |
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is ON. A Cloud Agent has been kicked off to fix the reported issue.
|
Bugbot Autofix resolved the bug found in the latest run.
|
|
@cursor, please fix CI (typescript is failing) |
Restore the original conditional logic to properly handle both File and FileUpload types. - File objects extend Blob and can be passed directly to fetch - FileUpload objects need .stream() called to get a ReadableStream for the fetch body - Added type assertion to help TypeScript with type narrowing This fixes the misleading type signature where File | FileUpload is accepted but only File was being handled correctly.
2e988d5 to
ffa164e
Compare



Updates various dependencies to their latest compatible versions.
Test Plan
CI=true npx playwright test tests/e2e/error-boundary.test.ts --retries=0 --workers=1was used to validate server/router behavior after dependency updates.npm run test:e2e:runwas started but not completed due to runtime length; full coverage is recommended via CI.Checklist
Screenshots
Note
Medium Risk
Mostly test/docs churn, but the cache DB init now throws when
CACHE_DATABASE_PATHis missing and changes file-deletion behavior on startup, which could impact deployments with misconfigured env or corrupted cache files.Overview
Updates runtime/test compatibility for dependency bumps by adjusting route loader tests to include
unstable_pattern(via sharedLOADER_ARGS_BASE) and tightening aFileUploadtype cast when streaming uploads.Hardens SQLite cache initialization in
cache.server.tsby failing fast whenCACHE_DATABASE_PATHis unset and by replacingunlinkSyncwith a saferrmSync(..., { force: true })retry path when the cache DB file is corrupt.Also includes documentation-only reformatting plus a new
docs/testing.mdprerequisite to copy.env.exampleto.envbefore running tests.Written by Cursor Bugbot for commit fb6b060. This will update automatically on new commits. Configure here.